[MLIR][ODS] Fully qualify namespace for mlir::Attribute in ODS generated code #168536
Conversation
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
|
@llvm/pr-subscribers-mlir-ods @llvm/pr-subscribers-mlir-core Author: None (BogdanDragosV) ChangesIn some cases, using clang compiler with restrictive setting, Full diff: https://github.com/llvm/llvm-project/pull/168536.diff 1 Files Affected:
diff --git a/mlir/include/mlir/IR/Properties.td b/mlir/include/mlir/IR/Properties.td
index a7ade0675b9bb..2830ba96fb787 100644
--- a/mlir/include/mlir/IR/Properties.td
+++ b/mlir/include/mlir/IR/Properties.td
@@ -468,7 +468,7 @@ class ArrayProp<Property elem = Property<>, string newSummary = ""> :
return $_diag() << "expected array attribute";
for (::mlir::Attribute elemAttr : arrayAttr) {
}] # _makePropStorage<elem, "elemVal">.ret # [{
- auto elemRes = [&](Attribute propAttr, }] # elem.storageType # [{& propStorage) -> ::mlir::LogicalResult {
+ auto elemRes = [&](::mlir::Attribute propAttr, }] # elem.storageType # [{& propStorage) -> ::mlir::LogicalResult {
}] # !subst("$_attr", "propAttr",
!subst("$_storage", "propStorage", elem.convertFromAttribute)) # [{
}(elemAttr, elemVal);
@@ -480,7 +480,7 @@ class ArrayProp<Property elem = Property<>, string newSummary = ""> :
}];
let convertToAttribute = [{
- SmallVector<Attribute> elems;
+ SmallVector<::mlir::Attribute> elems;
for (const auto& elemVal : $_storage) {
auto elemAttr = [&](const }] # elem.storageType #[{& propStorage) -> ::mlir::Attribute {
}] # !subst("$_storage", "propStorage", elem.convertToAttribute) # [{
@@ -647,7 +647,7 @@ class OptionalProp<Property p, bit canDelegateParsing = 1>
}
::mlir::Attribute presentAttr = arrayAttr[0];
}] # _makePropStorage<p, "presentVal">.ret # [{
- auto presentRes = [&](Attribute propAttr, }] # p.storageType # [{& propStorage) -> ::mlir::LogicalResult {
+ auto presentRes = [&](::mlir::Attribute propAttr, }] # p.storageType # [{& propStorage) -> ::mlir::LogicalResult {
}] # !subst("$_storage", "propStorage",
!subst("$_attr", "propAttr", p.convertFromAttribute)) # [{
}(presentAttr, presentVal);
|
What kind of "restrictive setting" are you referring to here? Can you share the error you're seeing? We should always fully qualify namespace in generic ODS because downstream can define dialects outside of the |
For our particular use case we've hit this error: ops.cpp.inc:904:27: error: unknown type name 'Attribute' |
|
Right, that seems like the case I was describing where your dialect isn't nested under the So unless I'm missing something, I'll update the PR title/description to reflect this! |
joker-eph
changed the title
🐧 Linux x64 Test Results
|
|
@BogdanDragosV Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR. Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues. How to do this, and the rest of the post-merge process, is covered in detail here. If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again. If you don't get any reports, no action is required from you. Your changes are working as expected, well done! |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/116/builds/21187 Here is the relevant piece of the build log for the reference |
4 participants
ODS generate code can be included and used outside of the
mlirnamespace and so referencesto symbols in the mlir namespace must be fully qualified.